Mailing-List: contact clanlib-devel-help@clanlib.org; run by ezmlm
Reply-To: clanlib-devel@clanlib.org
Date: Thu, 21 Aug 2003 17:53:26 +0200
From: Magnus Norddahl <mbn@clanlib.org>
To: clanlib-devel@clanlib.org
Subject: Re: CL_Library classes
Message-ID: <20030821155326.GA30522@dark.clansoft.dk>
References: <20030818125911.22616.qmail@cs06.tgv.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030818125911.22616.qmail@cs06.tgv.net>
User-Agent: Mutt/1.5.4i
Status: RO
Lines: 56
Xref: penpen.localdomain ClanLib.Devel:6901

Quoting sylvain HELLEGOUARCH (shellegouarch@programmationworld.com):

> Here is my CL_Library classes. The package offers three classes : 

Ok I've now looked at the attached files, adjusted them some and commited it
to cvs. I have not added the examples to CVS, seemed bit unclear which files
were supposed to do what.

A couple of notes:

1. To save me from spending a lot of time trying to figure out what exactly
you changed, it is of high importance that send changes in the form of a
real patch file.

You eg. added your new source files to some Makefile.am files, but I cannot
simply copy those over the versions I have - things might have changed
elsewhere in the files, and I have to confirm that the changes you did
indeed are correct changes.

To build a patch file, you can checkout an anonymous copy of our CVS
version, hack on that copy, and run the cvs command "cvs diff -u > my_patch"
to produce a patch. The obvious advantages of this approach is that you can
continue to code your changes while keeping your version up to date with
ours.

Alternatively you can use the Win32 PatchFile Maker available on
clanlib.org, which is a frontend for doing a "diff -uNr origClanLib
changedClanlib > my_patch" on a unix system.

2. Your classes do not follow the ClanLib "CL_ClassName_Generic" data hiding
system. Basically we do not ever put variables in the API classes to
minimize the chances of breaking binary compatibility. There should only be
one attribute in the API classes, called "CL_ClassName_Generic *impl;", and
inside your implementation you would put all member variables in the generic
class.

I commited your classes anyway because it looked like you had done a great
effort trying to follow the syntax and behavior of ClanLib in general. But
this should be fixed. :)

3. You use two spaces as indenting instead of a tab. Also there were some
cases where you put { on the same line as the conditional code. I fixed
these things before committing it.

Thanks for your contribution, we appreciate it. Hope this didn't scare you
away from contributing more stuff later on. :)

-- 
Magnus Norddahl,
Clansoft

---------------------------------------------------------------------
To unsubscribe, e-mail: clanlib-devel-unsubscribe@clanlib.org
For additional commands, e-mail: clanlib-devel-help@clanlib.org